Live TV Configuration Options#790
Conversation
…tent and guide channel identifier
New Configuration Options
The default value matches the client behavior since pre-3.0.0. Now users can instead show the channel number portion only or the name portion only if desired. Note: The title is shown in the OSD as well 
The default values matches the client behavior since 3.1.6. Logo only is how the client behaved 3.0.0-3.1.5. Title only is a new possibility. Sample ScreenshotsA few possible configurations Default settings (3.1.6+ Behavior)
Recreating 3.1.5 Behavior
Number-Only Title & Hidden Logo
|
|
Thank you. Pretty sure that will help. 🤞🏻 |
jimdogx
left a comment
jimdogx
left a comment
There was a problem hiding this comment.
Missing default english string in en_US translations file. That will get picked up and then translated to other languages for us.
|
Good catch, I just added them |
| @@ -0,0 +1,5 @@ | |||
| enum LiveTVChannelIdentifier | |||
| LOGO_AND_TITLE = "logoTitle" | |||
There was a problem hiding this comment.
For consistency. We don't use snake case in any other enums, only uppercase.
| LOGO_AND_TITLE = "logoTitle" | |
| LOGOANDTITLE = "logoTitle" |
source/enums/LiveTVChannelTitle.bs
Outdated
| @@ -0,0 +1,5 @@ | |||
| enum LiveTVChannelTitle | |||
| NUMBER_AND_NAME = "numberName" | |||
There was a problem hiding this comment.
| NUMBER_AND_NAME = "numberName" | |
| NUMBERANDNAME = "numberName" |
source/static/whatsNew/3.1.8.json
Outdated
| "author": "gabeluci" | ||
| }, | ||
| { | ||
| "description": "Add channel title content and guide channel identifier configuration options to Live TV", |
There was a problem hiding this comment.
Front load the word setting so users know this is a new setting.
"Add setting to configure live TV channel title and logo..."
components/data/ChannelData.bs
Outdated
| m.top.id = json.id | ||
| if isValid(json.number) | ||
| m.top.title = `${tr("CH")} ${json.number} ${json.name}` | ||
| if isValid(json.number) and not isStringEqual(channelTitleContent, LiveTVChannelTitle.NAME) |
There was a problem hiding this comment.
Inverse the condition so we don't test json.number when it is LiveTVChannelTitle.NAME
| if isValid(json.number) and not isStringEqual(channelTitleContent, LiveTVChannelTitle.NAME) | |
| if not isStringEqual(channelTitleContent, LiveTVChannelTitle.NAME) and isValid(json.number) |
settings/settings.json
Outdated
| "description": "Settings relating to Live TV.", | ||
| "children": [ | ||
| { | ||
| "title": "Channel Title Content", |
There was a problem hiding this comment.
| "title": "Channel Title Content", | |
| "title": "Channel Title Info", |
settings/settings.json
Outdated
| "children": [ | ||
| { | ||
| "title": "Channel Title Content", | ||
| "description": "What to use for the channel title.", |
There was a problem hiding this comment.
| "description": "What to use for the channel title.", | |
| "description": "Select what information to use as a channel's title.", |
settings/settings.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "title": "TV Guide Channel Identifier", |
There was a problem hiding this comment.
| "title": "TV Guide Channel Identifier", | |
| "title": "TV Guide Channel Display", |
settings/settings.json
Outdated
| }, | ||
| { | ||
| "title": "TV Guide Channel Identifier", | ||
| "description": "What to use for identifying a channel in the Live TV guide.", |
There was a problem hiding this comment.
| "description": "What to use for identifying a channel in the Live TV guide.", | |
| "description": "Select how to display a channel in the live TV guide.", |
4 participants
Changes
Add channel title content and guide channel identifier configuration options to Live TV. Show logo on the right and title text on the left when both are visible, to better align with other clients.
Issues
Fixes #788